fix(core): sync __drizzle_migrations when behind migration table#35406
Open
Bmasele wants to merge 1 commit into
Open
fix(core): sync __drizzle_migrations when behind migration table#35406Bmasele wants to merge 1 commit into
Bmasele wants to merge 1 commit into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Updated the description with proper checkboxes per the PR template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #35403
Type of change
What does this PR do?
The existing migration reconciliation only seeds the
migrationtable from__drizzle_migrations-- not the reverse. When the CLI binary auto-updates past the plugin's migration count,__drizzle_migrationsfalls behind. The task tool then fails because Drizzle's tracker doesn't know about columns added by later migrations.After the existing forward-seed (where an empty
migrationtable is populated from the old Drizzle journal), this adds a reverse-sync that backfills any migration IDs present in themigrationtable but missing from__drizzle_migrations. Uses sequential IDs after the current max, with'synced'as hash.How did you verify your code works?
Applied the equivalent SQL manually on a real database where
migrationhad 38 entries and__drizzle_migrationshad 21. After the backfill, both tables were in sync and the task tool ran without errors.Screenshots / recordings
N/A -- non-UI change.
Checklist